tipc: do not use tasklet_disable before tasklet_kill
authorXiaotian Feng <xtfeng@gmail.com>
Tue, 30 Oct 2012 22:06:01 +0000 (22:06 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 3 Nov 2012 19:10:14 +0000 (15:10 -0400)
If tasklet_disable() is called before related tasklet handled,
tasklet_kill will never be finished. tasklet_kill is enough.

Signed-off-by: Xiaotian Feng <dannyfeng@tencent.com>
Cc: Jon Maloy <jon.maloy@ericsson.com>
Cc: Allan Stephens <allan.stephens@windriver.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: tipc-discussion@lists.sourceforge.net
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/handler.c

index 111ff83..b36f0fc 100644 (file)
@@ -116,7 +116,6 @@ void tipc_handler_stop(void)
                return;
 
        handler_enabled = 0;
-       tasklet_disable(&tipc_tasklet);
        tasklet_kill(&tipc_tasklet);
 
        spin_lock_bh(&qitem_lock);