dmaengine: Revert "dmaengine: shdma: Fix runtime PM imbalance on error"
authorVinod Koul <vkoul@kernel.org>
Thu, 10 Mar 2022 04:43:20 +0000 (10:13 +0530)
committerVinod Koul <vkoul@kernel.org>
Thu, 10 Mar 2022 04:43:20 +0000 (10:13 +0530)
This reverts commit 455896c53d5b ("dmaengine: shdma: Fix runtime PM
imbalance on error") as the patch wrongly reduced the count on error and
did not bail out. So drop the count by reverting the patch .

Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/sh/shdma-base.c

index b26ed69..158e5e7 100644 (file)
@@ -115,10 +115,8 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx)
                ret = pm_runtime_get(schan->dev);
 
                spin_unlock_irq(&schan->chan_lock);
-               if (ret < 0) {
+               if (ret < 0)
                        dev_err(schan->dev, "%s(): GET = %d\n", __func__, ret);
-                       pm_runtime_put(schan->dev);
-               }
 
                pm_runtime_barrier(schan->dev);