driver core: Make use of returned value of dev_err_probe()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 21 Aug 2024 15:48:22 +0000 (18:48 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Aug 2024 07:37:38 +0000 (15:37 +0800)
Instead of assigning ret explicitly to the same value that is supplied
to dev_err_probe(), make use  of returned value of the latter.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240821154839.604259-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c

index 271a88a6311e16c1a2aa6ed12b9c14c897c4be8c..980c08901cd08755ed04aab7b92ee9c06d76bc50 100644 (file)
@@ -1084,10 +1084,8 @@ int device_links_check_suppliers(struct device *dev)
                        }
 
                        device_links_missing_supplier(dev);
-                       dev_err_probe(dev, -EPROBE_DEFER,
-                                     "supplier %s not ready\n",
-                                     dev_name(link->supplier));
-                       ret = -EPROBE_DEFER;
+                       ret = dev_err_probe(dev, -EPROBE_DEFER,
+                                           "supplier %s not ready\n", dev_name(link->supplier));
                        break;
                }
                WRITE_ONCE(link->status, DL_STATE_CONSUMER_PROBE);