[NET] netconsole: Remove bogus check
authorSatyam Sharma <satyam@infradead.org>
Fri, 10 Aug 2007 22:28:10 +0000 (15:28 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Wed, 10 Oct 2007 23:48:02 +0000 (16:48 -0700)
Based upon initial work by Keiichi Kii <k-keiichi@bx.jp.nec.com>.

The (!np.dev) check in write_msg() is bogus (always false), because: np.dev is
set by netpoll_setup(), which is called by init_netconsole() before
register_console(), so write_msg() cannot be triggered unless netpoll_setup()
successfully set np.dev.  Also np.dev cannot go away from under us, because
netpoll_setup() grabs us reference on it.  So let's remove the bogus check.

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Acked-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
Acked-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netconsole.c

index f1c2a2d..2c2aef1 100644 (file)
@@ -67,9 +67,6 @@ static void write_msg(struct console *con, const char *msg, unsigned int len)
        int frag, left;
        unsigned long flags;
 
-       if (!np.dev)
-               return;
-
        local_irq_save(flags);
 
        for (left = len; left;) {