iio: dac: ti-dac7311: Make use of the helper function dev_err_probe()
authorCai Huoqing <caihuoqing@baidu.com>
Tue, 28 Sep 2021 01:39:01 +0000 (09:39 +0800)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 19 Oct 2021 07:30:44 +0000 (08:30 +0100)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-8-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ti-dac7311.c

index 9d0b253..09218c3 100644 (file)
@@ -266,10 +266,9 @@ static int ti_dac_probe(struct spi_device *spi)
        ti_dac->resolution = spec->resolution;
 
        ti_dac->vref = devm_regulator_get(dev, "vref");
-       if (IS_ERR(ti_dac->vref)) {
-               dev_err(dev, "error to get regulator\n");
-               return PTR_ERR(ti_dac->vref);
-       }
+       if (IS_ERR(ti_dac->vref))
+               return dev_err_probe(dev, PTR_ERR(ti_dac->vref),
+                                    "error to get regulator\n");
 
        ret = regulator_enable(ti_dac->vref);
        if (ret < 0) {