linux ttyname: Change return type of is_pty from int to bool

is_pty returning a bool is fine since there's no possible outcome other than
true or false, and bool is used throughout the codebase.

Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>

diff --git a/ChangeLog b/ChangeLog
index 619423723031194e2901df82ea8ee91cdd16a59e..bb960c04bdda7754ffd94077d502c550be30e7c9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2017-11-15  Luke Shumaker  <lukeshu@parabola.nu>
 
+       * sysdeps/unix/sysv/linux/ttyname.h (is_pty): Change return type from
+       int to bool.
+
        * sysdeps/unix/sysv/linux/ttyname.h (is_pty): Update doc reference.
 
        * manual/terminal.texi (Is It a Terminal):

diff --git a/sysdeps/unix/sysv/linux/ttyname.h b/sysdeps/unix/sysv/linux/ttyname.h
index cbcdbab6079ad48bda9c8448b0621f3cd8f82d81..cdaf60fb871e2af0ce73dc76df5893ca0fbd93a6 100644 (file)
--- a/sysdeps/unix/sysv/linux/ttyname.h
+++ b/sysdeps/unix/sysv/linux/ttyname.h
@@ -16,6 +16,7 @@
    not, see <http://www.gnu.org/licenses/>.  */
 
 #include <unistd.h>
+#include <stdbool.h>
 #include <sys/sysmacros.h>
 #include <sys/types.h>
 #include <sys/stat.h>
@@ -23,7 +24,7 @@
 /* Return true if this is a UNIX98 pty device, as defined in
    linux/Documentation/devices.txt (on linux < 4.10) or
    linux/Documentation/admin-guide/devices.txt (on linux >= 4.10).  */
-static inline int
+static inline bool
 is_pty (struct stat64 *sb)
 {
 #ifdef _STATBUF_ST_RDEV