Staging: iio: Documentation: Added check for sscanf return value.
authorHeena Sirwani <heenasirwani@gmail.com>
Mon, 6 Oct 2014 11:34:43 +0000 (17:04 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 Oct 2014 02:29:08 +0000 (10:29 +0800)
The following patch fixes the following checkpatch.pl warning by adding
a check for sscanf return value.
WARNING: unchecked sscanf return value.

Signed-off-by: Heena Sirwani <heenasirwani@gmail.com>
Acked-by: Daniel Baluta <daniel.baluta@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/iio/Documentation/lsiio.c

index 3b436f1..98a0de0 100644 (file)
@@ -63,9 +63,12 @@ static int dump_one_device(const char *dev_dir_name)
 {
        char name[IIO_MAX_NAME_LENGTH];
        int dev_idx;
+       int retval;
 
-       sscanf(dev_dir_name + strlen(iio_dir) + strlen(type_device),
+       retval = sscanf(dev_dir_name + strlen(iio_dir) + strlen(type_device),
                        "%i", &dev_idx);
+       if (retval != 1)
+               return -EINVAL;
        read_sysfs_string("name", dev_dir_name, name);
        printf("Device %03d: %s\n", dev_idx, name);
 
@@ -78,9 +81,12 @@ static int dump_one_trigger(const char *dev_dir_name)
 {
        char name[IIO_MAX_NAME_LENGTH];
        int dev_idx;
+       int retval;
 
-       sscanf(dev_dir_name + strlen(iio_dir) + strlen(type_trigger),
+       retval = sscanf(dev_dir_name + strlen(iio_dir) + strlen(type_trigger),
                        "%i", &dev_idx);
+       if (retval != 1)
+               return -EINVAL;
        read_sysfs_string("name", dev_dir_name, name);
        printf("Trigger %03d: %s\n", dev_idx, name);
        return 0;