accel/habanalabs: always fetch pci addr_dec error info
authorOfir Bitton <obitton@habana.ai>
Mon, 24 Apr 2023 11:17:03 +0000 (14:17 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Thu, 8 Jun 2023 09:35:54 +0000 (12:35 +0300)
Due to missing indication of address decode source (LBW/HBW bus),
we should always try and fetch extended information.

Signed-off-by: Ofir Bitton <obitton@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/accel/habanalabs/gaudi2/gaudi2.c

index 240fecfab6087eb2652d1096388070426d21c4aa..d21ef9997d05c19e9c673684edf8f362005786bc 100644 (file)
@@ -8892,14 +8892,12 @@ static int gaudi2_print_pcie_addr_dec_info(struct hl_device *hdev, u16 event_typ
                        "err cause: %s", gaudi2_pcie_addr_dec_error_cause[i]);
                error_count++;
 
-               switch (intr_cause_data & BIT_ULL(i)) {
-               case PCIE_WRAP_PCIE_IC_SEI_INTR_IND_AXI_LBW_ERR_INTR_MASK:
-                       hl_check_for_glbl_errors(hdev);
-                       break;
-               case PCIE_WRAP_PCIE_IC_SEI_INTR_IND_BAD_ACCESS_INTR_MASK:
-                       gaudi2_print_pcie_mstr_rr_mstr_if_razwi_info(hdev, event_mask);
-                       break;
-               }
+               /*
+                * Always check for LBW and HBW additional info as the indication itself is
+                * sometimes missing
+                */
+               hl_check_for_glbl_errors(hdev);
+               gaudi2_print_pcie_mstr_rr_mstr_if_razwi_info(hdev, event_mask);
        }
 
        return error_count;