PM: hibernate: fix __setup handler error handling
authorRandy Dunlap <rdunlap@infradead.org>
Mon, 28 Feb 2022 22:05:32 +0000 (14:05 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 8 Apr 2022 12:23:07 +0000 (14:23 +0200)
[ Upstream commit ba7ffcd4c4da374b0f64666354eeeda7d3827131 ]

If an invalid value is used in "resumedelay=<seconds>", it is
silently ignored. Add a warning message and then let the __setup
handler return 1 to indicate that the kernel command line option
has been handled.

Fixes: 317cf7e5e85e3 ("PM / hibernate: convert simple_strtoul to kstrtoul")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Igor Zhbanov <i.zhbanov@omprussia.ru>
Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@omprussia.ru
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/power/hibernate.c

index b0888e9..d926852 100644 (file)
@@ -1326,7 +1326,7 @@ static int __init resumedelay_setup(char *str)
        int rc = kstrtouint(str, 0, &resume_delay);
 
        if (rc)
-               return rc;
+               pr_warn("resumedelay: bad option string '%s'\n", str);
        return 1;
 }