Fix Svace warnings & remove (void)

Change-Id: I45325c2a84503861fd20f6c01f2fdfd45b827393
Signed-off-by: Kiseok Chang <kiso.chang@samsung.com>

diff --git a/setting-about/src/setting-about-main.c b/setting-about/src/setting-about-main.c
index e35316a9abd5e625ec077f82f007a7acf196f5b2..f2898862928bef6e7dce679727dc93dd2b6897e4 100755 (executable)
--- a/setting-about/src/setting-about-main.c
+++ b/setting-about/src/setting-about-main.c
@@ -1344,7 +1344,7 @@ static int __generate_genlist(void *data)
                        "IDS_ST_MBODY_LEGAL_INFORMATION_ABB", NULL, NULL);
 
        /*////////////////////////////////////////////////////////////////// */
-       (void)setting_create_Gendial_field_titleItem(ad->md.genlist,
+       setting_create_Gendial_field_titleItem(ad->md.genlist,
                        &(ad->itc_group_item), "IDS_ST_BODY_DEVICE_INFO",
                        NULL);
        /*////////////////////////////////////////////////////////////////// */

diff --git a/setting-locktype/src/setting-locktype-main.c b/setting-locktype/src/setting-locktype-main.c
index 4e0dcff5c2bf7b7b64a38d3160cb1604f5314f29..2c5f0fe34707cb075ef8b54bab218542b70ed3eb 100755 (executable)
--- a/setting-locktype/src/setting-locktype-main.c
+++ b/setting-locktype/src/setting-locktype-main.c
@@ -639,7 +639,7 @@ static int _view_destroy(void *cb)
        ad->md.window = NULL;
 
 #if 0
-       (void) vconf_ignore_key_changed(VCONFKEY_SETAPPL_SCREEN_LOCK_TYPE_INT,
+       vconf_ignore_key_changed(VCONFKEY_SETAPPL_SCREEN_LOCK_TYPE_INT,
                        __lock_type_key_changed_cb);
 #endif
 

diff --git a/setting-network/src/setting-network-service-providers.c b/setting-network/src/setting-network-service-providers.c
index 764fd280863923eed970ed6eb92606e19c7b7b8d..15151908d5a93b9b2f7bbc4ef150e236d5e67ccd 100755 (executable)
--- a/setting-network/src/setting-network-service-providers.c
+++ b/setting-network/src/setting-network-service-providers.c
@@ -102,22 +102,22 @@ void select_network_app_control(SettingNetwork *ad)
                        SETTING_TRACE_ERROR("*** [ERR] tel_get_network_serving. ***");
        }
 
-       (void) vconf_notify_key_changed(VCONFKEY_TELEPHONY_NWNAME, __selected_network_change_cb, ad);
-       (void) vconf_notify_key_changed(VCONFKEY_TELEPHONY_SPN_DISP_CONDITION, __selected_network_change_cb, ad);
-       (void) vconf_notify_key_changed(VCONFKEY_TELEPHONY_SPN_NAME, __selected_network_change_cb, ad);
-       (void) vconf_notify_key_changed(VCONFKEY_TELEPHONY_SVCTYPE, __selected_network_change_cb, ad);
-       (void) vconf_notify_key_changed(VCONFKEY_TELEPHONY_FLIGHT_MODE, __selected_network_change_cb, ad);
+       vconf_notify_key_changed(VCONFKEY_TELEPHONY_NWNAME, __selected_network_change_cb, ad);
+       vconf_notify_key_changed(VCONFKEY_TELEPHONY_SPN_DISP_CONDITION, __selected_network_change_cb, ad);
+       vconf_notify_key_changed(VCONFKEY_TELEPHONY_SPN_NAME, __selected_network_change_cb, ad);
+       vconf_notify_key_changed(VCONFKEY_TELEPHONY_SVCTYPE, __selected_network_change_cb, ad);
+       vconf_notify_key_changed(VCONFKEY_TELEPHONY_FLIGHT_MODE, __selected_network_change_cb, ad);
        SETTING_TRACE_END;
 }
 
 void select_network_terminate(void)
 {
        SETTING_TRACE_BEGIN;
-       (void) vconf_ignore_key_changed(VCONFKEY_TELEPHONY_NWNAME, __selected_network_change_cb);
-       (void) vconf_ignore_key_changed(VCONFKEY_TELEPHONY_SPN_DISP_CONDITION, __selected_network_change_cb);
-       (void) vconf_ignore_key_changed(VCONFKEY_TELEPHONY_SPN_NAME, __selected_network_change_cb);
-       (void) vconf_ignore_key_changed(VCONFKEY_TELEPHONY_SVCTYPE, __selected_network_change_cb);
-       (void) vconf_ignore_key_changed(VCONFKEY_TELEPHONY_FLIGHT_MODE, __selected_network_change_cb);
+       vconf_ignore_key_changed(VCONFKEY_TELEPHONY_NWNAME, __selected_network_change_cb);
+       vconf_ignore_key_changed(VCONFKEY_TELEPHONY_SPN_DISP_CONDITION, __selected_network_change_cb);
+       vconf_ignore_key_changed(VCONFKEY_TELEPHONY_SPN_NAME, __selected_network_change_cb);
+       vconf_ignore_key_changed(VCONFKEY_TELEPHONY_SVCTYPE, __selected_network_change_cb);
+       vconf_ignore_key_changed(VCONFKEY_TELEPHONY_FLIGHT_MODE, __selected_network_change_cb);
 
        FREE(s_info.sel_network);
        SETTING_TRACE_END;

diff --git a/setting-smartmanager/smartmanager-data/src/smartmanager-data-usage-mobile-settings.c b/setting-smartmanager/smartmanager-data/src/smartmanager-data-usage-mobile-settings.c
index b8a4af0ff06731eb2b4d5c75577adab2e16aeac5..884abb87db306e35339d8ddd75cb759405515505 100755 (executable)
--- a/setting-smartmanager/smartmanager-data/src/smartmanager-data-usage-mobile-settings.c
+++ b/setting-smartmanager/smartmanager-data/src/smartmanager-data-usage-mobile-settings.c
@@ -293,12 +293,15 @@ static stc_callback_ret_e _get_and_unset_limit_restrictions_cb(stc_error_e resul
                if (STC_ERROR_NONE != ret) {
                        SETTING_TRACE_ERROR("stc_restriction_rule_create() error: %s",
                                                                                get_error_message(ret));
+                       free(subscriber_id);
                        return STC_CALLBACK_CONTINUE;
                }
 
                restrictions_res = set_mobile_restriction_rule_parameters(rule, subscriber_id, limit, warning_limit);
                if (restrictions_res != RESTRICTIONS_OK) {
                        SETTING_TRACE_ERROR("set_mobile_restriction_rule_parameters() error");
+                       stc_restriction_rule_destroy(rule);
+                       free(subscriber_id);
                        return STC_CALLBACK_CONTINUE;
                }
 
@@ -306,11 +309,13 @@ static stc_callback_ret_e _get_and_unset_limit_restrictions_cb(stc_error_e resul
                if (STC_ERROR_NONE != ret) {
                        SETTING_TRACE_ERROR("stc_unset_restriction() error: %s",
                                                                                get_error_message(ret));
+                       stc_restriction_rule_destroy(rule);
+                       free(subscriber_id);
                        return STC_CALLBACK_CONTINUE;
                }
 
-               free(subscriber_id);
        }
+       free(subscriber_id);
 
        SETTING_TRACE_ERROR("stc_unset_restriction() successful unset restriction");
        return STC_CALLBACK_CONTINUE;

diff --git a/setting-smartmanager/smartmanager-data/src/smartmanager-utils.c b/setting-smartmanager/smartmanager-data/src/smartmanager-utils.c
index 6465ffa78c736e35570c6d3ee86a3c73cf25b671..266e72ea7877e0117e3b7cf687bc605d4d88537e 100755 (executable)
--- a/setting-smartmanager/smartmanager-data/src/smartmanager-utils.c
+++ b/setting-smartmanager/smartmanager-data/src/smartmanager-utils.c
@@ -117,7 +117,7 @@ static bool _create_stats_list(stc_h stc, stc_iface_type_e iface,
                return true;
        }
 
-       (void)stc_stats_rule_destroy(rule);
+       stc_stats_rule_destroy(rule);
 
        return true;
 }
@@ -140,7 +140,7 @@ static bool _get_total_stats(stc_h stc, stc_iface_type_e iface_type,
        if (ret != STC_ERROR_NONE) {
                SETTING_TRACE_ERROR("stc_stats_rule_set_time_interval() error: %s",
                                                        get_error_message(ret));
-               (void)stc_stats_rule_destroy(rule);
+               stc_stats_rule_destroy(rule);
                return true;
        }
 
@@ -148,7 +148,7 @@ static bool _get_total_stats(stc_h stc, stc_iface_type_e iface_type,
        if (ret != STC_ERROR_NONE) {
                SETTING_TRACE_ERROR("stc_stats_rule_set_iface_type() error: %s",
                                                        get_error_message(ret));
-               (void)stc_stats_rule_destroy(rule);
+               stc_stats_rule_destroy(rule);
                return true;
        }
 
@@ -157,13 +157,13 @@ static bool _get_total_stats(stc_h stc, stc_iface_type_e iface_type,
        if (ret != STC_ERROR_NONE) {
                SETTING_TRACE_ERROR("stc_get_total_stats() error: %s",
                                                get_error_message(ret));
-               (void)stc_stats_rule_destroy(rule);
+               stc_stats_rule_destroy(rule);
                if (STC_ERROR_IN_PROGRESS == ret)
                        return false;
                return true;
        }
 
-       (void)stc_stats_rule_destroy(rule);
+       stc_stats_rule_destroy(rule);
 
        return true;
 }
@@ -208,12 +208,12 @@ static bool _get_restrictions(stc_h stc, stc_iface_type_e iface_type,
        if (STC_ERROR_NONE != ret) {
                SETTING_TRACE_ERROR("SIM stc_foreach_restriction() error: %s",
                                                        get_error_message(ret));
-               (void)stc_restriction_rule_destroy(rule);
+               stc_restriction_rule_destroy(rule);
                if (STC_ERROR_IN_PROGRESS == ret)
                        return false;
                return true;
        }
-       (void)stc_restriction_rule_destroy(rule);
+       stc_restriction_rule_destroy(rule);
 
        return true;
 }
@@ -249,7 +249,7 @@ restrictions_result set_mobile_restriction_rule_parameters(
 
        ret = stc_restriction_rule_set_app_id(rule, "TOTAL_DATACALL");
        if (STC_ERROR_NONE != ret) {
-               (void)stc_restriction_rule_destroy(rule);
+               stc_restriction_rule_destroy(rule);
                SETTING_TRACE_ERROR("stc_restriction_rule_set_app_id() error: %s",
                                                                                        get_error_message(ret));
                return RESTRICTIONS_ERROR;
@@ -257,7 +257,7 @@ restrictions_result set_mobile_restriction_rule_parameters(
 
        ret = stc_restriction_rule_set_iface_type(rule, STC_IFACE_DATACALL);
        if (STC_ERROR_NONE != ret) {
-               (void)stc_restriction_rule_destroy(rule);
+               stc_restriction_rule_destroy(rule);
                SETTING_TRACE_ERROR("stc_restriction_rule_set_iface_type() error: %s",
                                                                                        get_error_message(ret));
                return RESTRICTIONS_ERROR;
@@ -265,7 +265,7 @@ restrictions_result set_mobile_restriction_rule_parameters(
 
        ret = stc_restriction_rule_set_subscriber_id(rule, subscriber_id);
        if (STC_ERROR_NONE != ret) {
-               (void)stc_restriction_rule_destroy(rule);
+               stc_restriction_rule_destroy(rule);
                SETTING_TRACE_ERROR("stc_restriction_rule_set_subscriber_id() error:"\
                                                        "%s", get_error_message(ret));
 
@@ -274,7 +274,7 @@ restrictions_result set_mobile_restriction_rule_parameters(
 
        ret = stc_restriction_rule_set_limit(rule, limit);
        if (STC_ERROR_NONE != ret) {
-               (void)stc_restriction_rule_destroy(rule);
+               stc_restriction_rule_destroy(rule);
                SETTING_TRACE_ERROR("stc_restriction_rule_set_limit() error: %s",
                                                                                        get_error_message(ret));
                return RESTRICTIONS_ERROR;
@@ -282,7 +282,7 @@ restrictions_result set_mobile_restriction_rule_parameters(
 
        ret = stc_restriction_rule_set_warning_limit(rule, warning_limit);
        if (STC_ERROR_NONE != ret) {
-               (void)stc_restriction_rule_destroy(rule);
+               stc_restriction_rule_destroy(rule);
                SETTING_TRACE_ERROR("stc_restriction_rule_set_warning_limit() error: %s",
                                                                                        get_error_message(ret));
                return RESTRICTIONS_ERROR;
@@ -310,20 +310,20 @@ restrictions_result set_mobile_limit_restrictions(stc_h stc_handle,
        result = set_mobile_restriction_rule_parameters(rule, subscriber_id, limit,
                                                                                                        warning_limit);
        if (RESTRICTIONS_OK != result) {
-               (void)stc_restriction_rule_destroy(rule);
-                               SETTING_TRACE_ERROR("set_restriction_rule_parameters() error");
+               SETTING_TRACE_ERROR("set_restriction_rule_parameters() error");
+               stc_restriction_rule_destroy(rule);
                return result;
        }
 
        ret = stc_set_restriction(stc_handle, rule);
        if (STC_ERROR_NONE != ret) {
-               (void)stc_restriction_rule_destroy(rule);
                SETTING_TRACE_ERROR("stc_set_restriction() error: %s",
                                                                                        get_error_message(ret));
+               stc_restriction_rule_destroy(rule);
                return RESTRICTIONS_ERROR;
        }
 
-       (void)stc_restriction_rule_destroy(rule);
+       stc_restriction_rule_destroy(rule);
        SETTING_TRACE_END;
        return RESTRICTIONS_OK;
 }

diff --git a/setting-time/src/setting-time-main.c b/setting-time/src/setting-time-main.c
index bbdd06c8bbf8f23a5b56ca461859f1c299c1da30..6f594db65b0c65964978fb257c432afc343ae969 100755 (executable)
--- a/setting-time/src/setting-time-main.c
+++ b/setting-time/src/setting-time-main.c
@@ -1389,7 +1389,7 @@ static void setting_time_main_chk_btn_cb(void *data, Evas_Object *obj,
                setting_get_bool_slp_key(BOOL_SLP_SETTING_AUTOMATIC_TIME_UPDATE,
                                                                 &bvalue, &err);
                if (bvalue) {
-                       (void) setting_set_bool_slp_key(
+                       setting_set_bool_slp_key(
                                        BOOL_SLP_SETTING_AUTOMATIC_TIME_UPDATE,
                                        SETTING_ON_OFF_BTN_OFF, &err);
                        setting_update_gl_item_chk_status(ad->data_auto, 0);
@@ -1499,7 +1499,6 @@ static void setting_time_main_mouse_up_Gendial_list_cb(
                setting_update_gl_item_chk_status(list_item, !old_status);
                int err = 0;
                if (!list_item->chk_status) {
-                       (void)
                        setting_set_bool_slp_key
                        (BOOL_SLP_SETTING_AUTOMATIC_TIME_UPDATE,
                         SETTING_ON_OFF_BTN_OFF, &err);