Re: [perl #24926] chop/~ mangles UTF8 [PATCH]

Message-ID: <lrn08m7wkh.fsf@caliper.activestate.com>
(test rewritten to fit in blead)

p4raw-id: //depot/perl@22180

diff --git a/pp.c b/pp.c
index 8898735..6f3703d 100644 (file)
--- a/pp.c
+++ b/pp.c
@@ -2417,6 +2417,7 @@ PP(pp_complement)
              *result = '\0';
              result -= nchar;
              sv_setpvn(TARG, (char*)result, nchar);
+             SvUTF8_off(TARG);
          }
          Safefree(result);
          SETs(TARG);

diff --git a/t/op/bop.t b/t/op/bop.t
index d5315a8..f6ef8ef 100755 (executable)
--- a/t/op/bop.t
+++ b/t/op/bop.t
@@ -9,7 +9,7 @@ BEGIN {
     @INC = '../lib';
 }
 
-print "1..143\n";
+print "1..145\n";
 
 # numerics
 print ((0xdead & 0xbeef) == 0x9ead ? "ok 1\n" : "not ok 1\n");
@@ -330,3 +330,8 @@ is(stores($y), 0);
 is(~~$y, "c");
 is(fetches($y), 1);
 is(stores($y), 0);
+
+$a = "\0\x{100}"; chop($a);
+ok(utf8::is_utf8($a)); # make sure UTF8 flag is still there
+$a = ~$a;
+is($a, "\xFF", "~ works with utf-8");