staging:rtl8192u: Refactor DELBA_PARAM_SET - Style
authorJohn Whitmore <johnfwhitmore@gmail.com>
Tue, 21 Aug 2018 17:15:28 +0000 (18:15 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Aug 2018 17:24:30 +0000 (19:24 +0200)
Remove the typedef directive from union DELBA_PARAM_SET, to clear the
checkpatch issue with CamelCase naming.

Rename the union to lowercase to comply with the coding standard.

These changes are coding style changes which should have no impact on
runtime code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192u/ieee80211/rtl819x_BA.h
drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c

index 8beae1a..10e81c3 100644 (file)
@@ -40,7 +40,7 @@ union ba_param_set {
        } field;
 };
 
-typedef union _DELBA_PARAM_SET {
+union delba_param_set {
        u8 charData[2];
        u16 shortData;
        struct {
@@ -48,7 +48,7 @@ typedef union _DELBA_PARAM_SET {
                u16 Initiator:1;
                u16 TID:4;
        } field;
-} DELBA_PARAM_SET, *PDELBA_PARAM_SET;
+};
 
 typedef struct _BA_RECORD {
        struct timer_list               Timer;
index 42f458b..931123f 100644 (file)
@@ -187,7 +187,7 @@ static struct sk_buff *ieee80211_DELBA(
        u16                      ReasonCode
        )
 {
-       DELBA_PARAM_SET DelbaParamSet;
+       union delba_param_set   DelbaParamSet;
        struct sk_buff *skb = NULL;
         struct rtl_80211_hdr_3addr *Delba = NULL;
        u8 *tag = NULL;
@@ -543,7 +543,7 @@ OnADDBARsp_Reject:
 int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb)
 {
         struct rtl_80211_hdr_3addr *delba = NULL;
-       PDELBA_PARAM_SET        pDelBaParamSet = NULL;
+       union delba_param_set   *pDelBaParamSet = NULL;
        u8                      *dst = NULL;
 
        if (skb->len < sizeof(struct rtl_80211_hdr_3addr) + 6) {
@@ -563,7 +563,7 @@ int ieee80211_rx_DELBA(struct ieee80211_device *ieee, struct sk_buff *skb)
        IEEE80211_DEBUG_DATA(IEEE80211_DL_DATA|IEEE80211_DL_BA, skb->data, skb->len);
        delba = (struct rtl_80211_hdr_3addr *)skb->data;
        dst = &delba->addr2[0];
-       pDelBaParamSet = (PDELBA_PARAM_SET)&delba->payload[2];
+       pDelBaParamSet = (union delba_param_set *)&delba->payload[2];
 
        if (pDelBaParamSet->field.Initiator == 1) {
                struct rx_ts_record *pRxTs;