brcmfmac: merge two remaining brcmf_err macros
authorRafał Miłecki <rafal@milecki.pl>
Thu, 2 Feb 2017 21:33:15 +0000 (22:33 +0100)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 8 Feb 2017 15:23:39 +0000 (17:23 +0200)
Now we always have __brcmf_err function we can do perfectly fine with
just one macro.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h

index 441a666..0661261 100644 (file)
 
 __printf(2, 3)
 void __brcmf_err(const char *func, const char *fmt, ...);
-#ifndef CONFIG_BRCM_TRACING
-/* Macro for error messages. net_ratelimit() is used when driver
- * debugging is not selected. When debugging the driver error
- * messages are as important as other tracing or even more so.
+/* Macro for error messages. When debugging / tracing the driver all error
+ * messages are important to us.
  */
 #define brcmf_err(fmt, ...)                                            \
        do {                                                            \
-               if (IS_ENABLED(CONFIG_BRCMDBG) || net_ratelimit())      \
+               if (IS_ENABLED(CONFIG_BRCMDBG) ||                       \
+                   IS_ENABLED(CONFIG_BRCM_TRACING) ||                  \
+                   net_ratelimit())                                    \
                        __brcmf_err(__func__, fmt, ##__VA_ARGS__);      \
        } while (0)
-#else
-#define brcmf_err(fmt, ...) \
-       __brcmf_err(__func__, fmt, ##__VA_ARGS__)
-#endif
 
 #if defined(DEBUG) || defined(CONFIG_BRCM_TRACING)
 __printf(3, 4)