dmaengine: stm32-dmamux: use reset controller only at probe time
authorEtienne Carriere <etienne.carriere@st.com>
Tue, 28 Jan 2020 09:41:57 +0000 (10:41 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 24 Feb 2020 16:52:44 +0000 (22:22 +0530)
Remove reset controller reference from device instance since it is
used only at probe time.

Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Amelie Delaunay <amelie.delaunay@st.com>
Link: https://lore.kernel.org/r/20200128094158.20361-4-amelie.delaunay@st.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/stm32-dmamux.c

index a862d33..1dfecba 100644 (file)
@@ -35,7 +35,6 @@ struct stm32_dmamux {
 struct stm32_dmamux_data {
        struct dma_router dmarouter;
        struct clk *clk;
-       struct reset_control *rst;
        void __iomem *iomem;
        u32 dma_requests; /* Number of DMA requests connected to DMAMUX */
        u32 dmamux_requests; /* Number of DMA requests routed toward DMAs */
@@ -182,6 +181,7 @@ static int stm32_dmamux_probe(struct platform_device *pdev)
        struct stm32_dmamux_data *stm32_dmamux;
        struct resource *res;
        void __iomem *iomem;
+       struct reset_control *rst;
        int i, count, ret;
        u32 dma_req;
 
@@ -265,11 +265,11 @@ static int stm32_dmamux_probe(struct platform_device *pdev)
                return ret;
        }
 
-       stm32_dmamux->rst = devm_reset_control_get(&pdev->dev, NULL);
-       if (!IS_ERR(stm32_dmamux->rst)) {
-               reset_control_assert(stm32_dmamux->rst);
+       rst = devm_reset_control_get(&pdev->dev, NULL);
+       if (!IS_ERR(rst)) {
+               reset_control_assert(rst);
                udelay(2);
-               reset_control_deassert(stm32_dmamux->rst);
+               reset_control_deassert(rst);
        }
 
        stm32_dmamux->iomem = iomem;