Add to same comdate group only if set (PR middle-end/90899)

2019-07-03  Martin Liska  <mliska@suse.cz>

	PR middle-end/90899
	* multiple_target.c (create_dispatcher_calls): Add to comdat
	group only if set for ifunc.
2019-07-03  Martin Liska  <mliska@suse.cz>

	PR middle-end/90899
	* gcc.target/i386/pr90899.c: New test.

From-SVN: r272992

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 3d1a07a..f2f6990 100644 (file)
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,11 @@
 2019-07-03  Martin Liska  <mliska@suse.cz>
 
+       PR middle-end/90899
+       * multiple_target.c (create_dispatcher_calls): Add to comdat
+       group only if set for ifunc.
+
+2019-07-03  Martin Liska  <mliska@suse.cz>
+
        PR target/88056
        * config/i386/host-mingw32.c (mingw32_gt_pch_use_address):
        Define local_object_name in outer scope in order to handle

diff --git a/gcc/multiple_target.c b/gcc/multiple_target.c
index fa194d4..7aea684 100644 (file)
--- a/gcc/multiple_target.c
+++ b/gcc/multiple_target.c
@@ -158,7 +158,8 @@ create_dispatcher_calls (struct cgraph_node *node)
            {
              symtab_node *source = ref->referring;
              source->create_reference (inode, IPA_REF_ALIAS);
-             source->add_to_same_comdat_group (inode);
+             if (inode->get_comdat_group ())
+               source->add_to_same_comdat_group (inode);
            }
          else
            gcc_unreachable ();

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index fc960bb..512e86c 100644 (file)
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2019-07-03  Martin Liska  <mliska@suse.cz>
+
+       PR middle-end/90899
+       * gcc.target/i386/pr90899.c: New test.
+
 2019-07-03  Jakub Jelinek  <jakub@redhat.com>
 
        PR tree-optimization/91033

diff --git a/gcc/testsuite/gcc.target/i386/pr90899.c b/gcc/testsuite/gcc.target/i386/pr90899.c
new file mode 100644 (file)
index 0000000..e0e2d5a
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr90899.c
@@ -0,0 +1,6 @@
+/* PR middle-end/90899 */
+/* { dg-do compile } */
+/* { dg-require-ifunc "" } */
+
+__attribute__ ((target_clones ("default", "arch=slm"))) static int f () { return 0; }
+__attribute__ ((alias ("f"))) __typeof (f) g;