powerpc/fsl_pci: Fix ptr_ret.cocci warnings
authorVasyl Gomonovych <gomonovych@gmail.com>
Mon, 27 Nov 2017 21:37:33 +0000 (22:37 +0100)
committerScott Wood <oss@buserror.net>
Sun, 21 Jan 2018 05:08:46 +0000 (23:08 -0600)
arch/powerpc/sysdev/fsl_pci.c:1307:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
Signed-off-by: Scott Wood <oss@buserror.net>
arch/powerpc/sysdev/fsl_pci.c

index 0c524c2..dd89df7 100644 (file)
@@ -1304,10 +1304,8 @@ static int add_err_dev(struct platform_device *pdev)
                                                   pdev->resource,
                                                   pdev->num_resources,
                                                   &pd, sizeof(pd));
-       if (IS_ERR(errdev))
-               return PTR_ERR(errdev);
 
-       return 0;
+       return PTR_ERR_OR_ZERO(errdev);
 }
 
 static int fsl_pci_probe(struct platform_device *pdev)