clk: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:01 +0000 (08:47 -0600)
committerStephen Boyd <sboyd@kernel.org>
Wed, 15 Mar 2023 00:35:38 +0000 (17:35 -0700)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144701.1541504-1-robh@kernel.org
Acked-by: Chunyan Zhang <zhang.lyra@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/clk.c
drivers/clk/sprd/common.c

index ae07685..f7528d7 100644 (file)
@@ -4880,8 +4880,8 @@ static struct device_node *get_clk_provider_node(struct device *dev)
        np = dev->of_node;
        parent_np = dev->parent ? dev->parent->of_node : NULL;
 
-       if (!of_find_property(np, "#clock-cells", NULL))
-               if (of_find_property(parent_np, "#clock-cells", NULL))
+       if (!of_property_present(np, "#clock-cells"))
+               if (of_property_present(parent_np, "#clock-cells"))
                        np = parent_np;
 
        return np;
index ce81e40..1a3795a 100644 (file)
@@ -44,7 +44,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev,
        struct device_node *node = dev->of_node, *np;
        struct regmap *regmap;
 
-       if (of_find_property(node, "sprd,syscon", NULL)) {
+       if (of_property_present(node, "sprd,syscon")) {
                regmap = syscon_regmap_lookup_by_phandle(node, "sprd,syscon");
                if (IS_ERR(regmap)) {
                        pr_err("%s: failed to get syscon regmap\n", __func__);