[IndVars][NFC] Separate creation of condition and replacement in foldExit
authorMax Kazantsev <mkazantsev@azul.com>
Mon, 12 Dec 2022 10:48:42 +0000 (17:48 +0700)
committerMax Kazantsev <mkazantsev@azul.com>
Mon, 12 Dec 2022 10:59:45 +0000 (17:59 +0700)
It is a preparatory step for further improvements.

llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

index 9d666f7..55a22ae 100644 (file)
@@ -1298,13 +1298,19 @@ static void replaceExitCond(BranchInst *BI, Value *NewCond,
     DeadInsts.emplace_back(OldCond);
 }
 
-static void foldExit(const Loop *L, BasicBlock *ExitingBB, bool IsTaken,
-                     SmallVectorImpl<WeakTrackingVH> &DeadInsts) {
+static Constant *createFoldedExitCond(const Loop *L, BasicBlock *ExitingBB,
+                                      bool IsTaken) {
   BranchInst *BI = cast<BranchInst>(ExitingBB->getTerminator());
   bool ExitIfTrue = !L->contains(*succ_begin(ExitingBB));
   auto *OldCond = BI->getCondition();
-  auto *NewCond =
-      ConstantInt::get(OldCond->getType(), IsTaken ? ExitIfTrue : !ExitIfTrue);
+  return ConstantInt::get(OldCond->getType(),
+                          IsTaken ? ExitIfTrue : !ExitIfTrue);
+}
+
+static void foldExit(const Loop *L, BasicBlock *ExitingBB, bool IsTaken,
+                     SmallVectorImpl<WeakTrackingVH> &DeadInsts) {
+  BranchInst *BI = cast<BranchInst>(ExitingBB->getTerminator());
+  auto *NewCond = createFoldedExitCond(L, ExitingBB, IsTaken);
   replaceExitCond(BI, NewCond, DeadInsts);
 }