hugetlbfs: use helper macro SZ_1{K,M}
authorMiaohe Lin <linmiaohe@huawei.com>
Tue, 26 Jul 2022 14:29:14 +0000 (22:29 +0800)
committerakpm <akpm@linux-foundation.org>
Sat, 30 Jul 2022 01:07:19 +0000 (18:07 -0700)
Patch series "A few cleanup and fixup patches for hugetlbfs", v2.

This series contains a few cleaup patches to remove unneeded forward
declaration, use helper macro and so on.  More details can be found in the
respective changelogs.

This patch (of 5):

Use helper macro SZ_1K and SZ_1M to do the size conversion.  Minor
readability improvement.

Link: https://lkml.kernel.org/r/20220726142918.51693-1-linmiaohe@huawei.com
Link: https://lkml.kernel.org/r/20220726142918.51693-2-linmiaohe@huawei.com
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/hugetlbfs/inode.c

index 02eb72351b15be706e6734e40a663c70da80efd9..3f58707694510921b12dd016b5809e7300852518 100644 (file)
@@ -1320,7 +1320,7 @@ static int hugetlbfs_parse_param(struct fs_context *fc, struct fs_parameter *par
                ps = memparse(param->string, &rest);
                ctx->hstate = size_to_hstate(ps);
                if (!ctx->hstate) {
-                       pr_err("Unsupported page size %lu MB\n", ps >> 20);
+                       pr_err("Unsupported page size %lu MB\n", ps / SZ_1M);
                        return -EINVAL;
                }
                return 0;
@@ -1566,7 +1566,7 @@ static struct vfsmount *__init mount_one_hugetlbfs(struct hstate *h)
        }
        if (IS_ERR(mnt))
                pr_err("Cannot mount internal hugetlbfs for page size %luK",
-                      huge_page_size(h) >> 10);
+                      huge_page_size(h) / SZ_1K);
        return mnt;
 }