plugins: remove unused gsignond_plugin_proxy_factory_add_plugin()
authorAlexander Kanavin <alexander.kanavin@intel.com>
Thu, 13 Feb 2014 15:40:49 +0000 (17:40 +0200)
committerAlexander Kanavin <alexander.kanavin@intel.com>
Thu, 13 Feb 2014 15:40:49 +0000 (17:40 +0200)
src/daemon/plugins/gsignond-plugin-proxy-factory.c
src/daemon/plugins/gsignond-plugin-proxy-factory.h
test/plugins/pluginproxytest.c

index 8235da3..5eb54f5 100644 (file)
@@ -331,27 +331,6 @@ gsignond_plugin_proxy_factory_get_plugin(GSignondPluginProxyFactory* factory,
     return proxy;
 }
 
-gboolean gsignond_plugin_proxy_factory_add_plugin(
-    GSignondPluginProxyFactory* factory,
-    GSignondPluginProxy* proxy)
-{
-    g_return_val_if_fail (factory && GSIGNOND_IS_PLUGIN_PROXY_FACTORY(factory), FALSE);
-    g_return_val_if_fail (proxy && GSIGNOND_IS_PLUGIN_PROXY(proxy), FALSE);
-    
-    gchar* plugin_type = NULL;
-    g_object_get (proxy, "type", &plugin_type, NULL);
-
-    if (g_hash_table_contains(factory->plugins, plugin_type)) {
-        g_free(plugin_type);
-        return FALSE;
-    }
-    g_object_ref(proxy);
-    DBG("add plugin %s -> %p", plugin_type, proxy);
-    g_hash_table_insert(factory->plugins, plugin_type, proxy);
-
-    return TRUE;
-}
-
 const gchar** 
 gsignond_plugin_proxy_factory_get_plugin_types(
    GSignondPluginProxyFactory* factory)
index bed020c..1f1898f 100644 (file)
@@ -67,10 +67,6 @@ GSignondPluginProxy*
 gsignond_plugin_proxy_factory_get_plugin(GSignondPluginProxyFactory* factory,
                                          const gchar* plugin_type);
 
-gboolean gsignond_plugin_proxy_factory_add_plugin(
-    GSignondPluginProxyFactory* factory,
-    GSignondPluginProxy* proxy);
-    
 const gchar** 
 gsignond_plugin_proxy_factory_get_plugin_types(
    GSignondPluginProxyFactory* factory);
index 410d2bb..3c2fbd9 100644 (file)
@@ -491,30 +491,6 @@ START_TEST (test_pluginproxyfactory_get)
 }
 END_TEST
 
-START_TEST (test_pluginproxyfactory_add)
-{
-    DBG("");
-    GSignondConfig* config = gsignond_config_new();
-    fail_if(config == NULL);
-    
-    GSignondPluginProxyFactory* factory = gsignond_plugin_proxy_factory_new(
-            config);
-    fail_if(factory == NULL);
-
-    GSignondPluginProxy* proxy = _make_plugin_proxy(config, "password");
-    fail_if (proxy == NULL);
-    fail_if(gsignond_plugin_proxy_factory_add_plugin(factory, proxy) == FALSE);
-    fail_if(gsignond_plugin_proxy_factory_add_plugin(factory, proxy) == TRUE);
-    fail_if(gsignond_plugin_proxy_factory_get_plugin(factory, "password")
-            != proxy);
-    g_object_unref(proxy);
-    
-    g_object_unref(proxy);
-    g_object_unref(factory);
-    g_object_unref(config);
-}
-END_TEST
-
 typedef struct {
     GSignondPluginProxyFactory *factory;
     GSignondPluginProxy *proxy;
@@ -659,7 +635,6 @@ Suite* pluginproxy_suite (void)
     tcase_add_test (tc_core, test_pluginproxy_process_queue_cancel);
     tcase_add_test (tc_core, test_pluginproxyfactory_methods_and_mechanisms);
     tcase_add_test (tc_core, test_pluginproxyfactory_get);
-    tcase_add_test (tc_core, test_pluginproxyfactory_add);
     tcase_add_test (tc_core, test_pluginproxyfactory_proxy_timeout);
 
     suite_add_tcase (s, tc_core);