seccomp: improve debug logging
authorLennart Poettering <lennart@poettering.net>
Wed, 13 Sep 2017 17:57:32 +0000 (19:57 +0200)
committerLennart Poettering <lennart@poettering.net>
Thu, 14 Sep 2017 13:45:21 +0000 (15:45 +0200)
Let's log explicitly at debug level if we encounter a syscall or group
that doesn#t exist at all.

src/shared/seccomp-util.c

index e282469..5e78a08 100644 (file)
@@ -799,8 +799,10 @@ int seccomp_add_syscall_filter_item(scmp_filter_ctx *seccomp, const char *name,
                 const SyscallFilterSet *other;
 
                 other = syscall_filter_set_find(name);
-                if (!other)
+                if (!other) {
+                        log_debug("Filter set %s is not known!", name);
                         return -EINVAL;
+                }
 
                 r = seccomp_add_syscall_filter_set(seccomp, other, action, exclude);
                 if (r < 0)
@@ -809,8 +811,10 @@ int seccomp_add_syscall_filter_item(scmp_filter_ctx *seccomp, const char *name,
                 int id;
 
                 id = seccomp_syscall_resolve_name(name);
-                if (id == __NR_SCMP_ERROR)
+                if (id == __NR_SCMP_ERROR) {
+                        log_debug("System call %s is not known!", name);
                         return -EINVAL; /* Not known at all? Then that's a real error */
+                }
 
                 r = seccomp_rule_add_exact(seccomp, action, id, 0);
                 if (r < 0)