RenderSVGRoot should inherit from RenderReplaced

https://bugs.webkit.org/show_bug.cgi?id=76446

Reviewed by Pavel Feldman.

Fix Chromium specific problem with svg/text/select-x-list-4.svg, making it fail on the bots.
After transforming the endPos.x + 1 -> absEndPos.x, subtract -1 again, to be sure we don't
select text too far after the end position, making the selection currently disappear, which
is a bug, but can be avoided in this testcase.

* platform/chromium/test_expectations.txt: Unskip test.
* svg/text/resources/SelectionTestCase.js:
(selectRange): Subtract -1 from absEndPos.x.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
index 212cee4..ddfb522 100644 (file)
--- a/LayoutTests/ChangeLog
+++ b/LayoutTests/ChangeLog
@@ -1,3 +1,19 @@
+2012-01-19  Nikolas Zimmermann  <nzimmermann@rim.com>
+
+        RenderSVGRoot should inherit from RenderReplaced
+        https://bugs.webkit.org/show_bug.cgi?id=76446
+
+        Reviewed by Pavel Feldman.
+
+        Fix Chromium specific problem with svg/text/select-x-list-4.svg, making it fail on the bots.
+        After transforming the endPos.x + 1 -> absEndPos.x, subtract -1 again, to be sure we don't
+        select text too far after the end position, making the selection currently disappear, which
+        is a bug, but can be avoided in this testcase.
+
+        * platform/chromium/test_expectations.txt: Unskip test.
+        * svg/text/resources/SelectionTestCase.js:
+        (selectRange): Subtract -1 from absEndPos.x.
+
 2012-01-19  Csaba Osztrogonác  <ossy@webkit.org>
 
         [Qt] Unreviewed gardening. Unskip now passing tests.

diff --git a/LayoutTests/platform/chromium/test_expectations.txt b/LayoutTests/platform/chromium/test_expectations.txt
index fca14ae..a204266 100644 (file)
--- a/LayoutTests/platform/chromium/test_expectations.txt
+++ b/LayoutTests/platform/chromium/test_expectations.txt
@@ -3856,8 +3856,6 @@ BUGWK76580 : media/media-document-audio-repaint.html = IMAGE PASS
 
 BUGWK76562 : fast/canvas/webgl/drawingbuffer-test.html = TEXT
 
-BUGWK76446 : svg/text/select-x-list-4.svg = IMAGE+TEXT
-
 // This test is passing, but it doesn't seem possible to add GPU+Leopard specific baselines.
 BUGJAMESR LEOPARD GPU : fast/canvas/quadraticCurveTo.xml = IMAGE
 

diff --git a/LayoutTests/svg/text/resources/SelectionTestCase.js b/LayoutTests/svg/text/resources/SelectionTestCase.js
index f94832b..a02319d 100644 (file)
--- a/LayoutTests/svg/text/resources/SelectionTestCase.js
+++ b/LayoutTests/svg/text/resources/SelectionTestCase.js
@@ -66,6 +66,7 @@ function selectRange(id, start, end, expectedText) {
 
         var absStartPos = toAbsoluteCoordinates(startPos, element);
         var absEndPos = toAbsoluteCoordinates(endPos, element);
+        absEndPos.x -= 1;
 
         // Move to selection origin and hold down mouse
         eventSender.mouseMoveTo(absStartPos.x, absStartPos.y);