vc4: Fix vc4_fence_server_sync() on pre-syncobj kernels.
authorEric Anholt <eric@anholt.net>
Tue, 7 Aug 2018 19:15:03 +0000 (12:15 -0700)
committerEric Anholt <eric@anholt.net>
Wed, 8 Aug 2018 00:00:49 +0000 (17:00 -0700)
We won't have an FD if we're just having the server wait on a fence
created by eglCreateSyncKHR().  Our seqno fences will happen in order, so
server-side waits are no-ops in that case.  Fixes
dEQP-EGL.functional.sharing.gles2.multithread.simple_egl_server_sync.buffers.gen_delete

Fixes: b0acc3a5628c ("broadcom/vc4: Native fence fd support")

src/gallium/drivers/vc4/vc4_fence.c

index fac9df3..0dbfbe9 100644 (file)
@@ -121,7 +121,8 @@ vc4_fence_server_sync(struct pipe_context *pctx,
         struct vc4_context *vc4 = vc4_context(pctx);
         struct vc4_fence *fence = vc4_fence(pfence);
 
-        sync_accumulate("vc4", &vc4->in_fence_fd, fence->fd);
+        if (fence->fd >= 0)
+                sync_accumulate("vc4", &vc4->in_fence_fd, fence->fd);
 }
 
 static int