rtnetlink: use nlmsg_notify() in rtnetlink_send()

The netlink_{broadcast, unicast} don't deal with 'if (err > 0' statement
but nlmsg_{multicast, unicast} do. The nlmsg_notify() contains them.
so use nlmsg_notify() instead. so that the caller wouldn't deal with
'if (err > 0' statement.

v2: use nlmsg_notify() will do well.

Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index f6af3e74fc445a1db118a01d39aeb614c26580c5..670d74ab91ae0299407536d16817ff86776cc5f4 100644 (file)
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -710,15 +710,8 @@ out:
 int rtnetlink_send(struct sk_buff *skb, struct net *net, u32 pid, unsigned int group, int echo)
 {
        struct sock *rtnl = net->rtnl;
-       int err = 0;
 
-       NETLINK_CB(skb).dst_group = group;
-       if (echo)
-               refcount_inc(&skb->users);
-       netlink_broadcast(rtnl, skb, pid, group, GFP_KERNEL);
-       if (echo)
-               err = netlink_unicast(rtnl, skb, pid, MSG_DONTWAIT);
-       return err;
+       return nlmsg_notify(rtnl, skb, pid, group, echo, GFP_KERNEL);
 }
 
 int rtnl_unicast(struct sk_buff *skb, struct net *net, u32 pid)