qt: always update the sink_retrieved flag when the sink retrieves

Fixes a case where adding a qmlgloverlay element after an existing
qmlglsink elements was already in the pipeline would create an entirely
separate GstGLDisplay pointing to the same underlying display resource.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/1050>

diff --git a/ext/qt/gstqtglutility.cc b/ext/qt/gstqtglutility.cc
index 6d413bce255235fe37ada6f778740511fa9e710a..b38e16fae88e49353dadfcec8ff63315c6bab2f6 100644 (file)
--- a/ext/qt/gstqtglutility.cc
+++ b/ext/qt/gstqtglutility.cc
@@ -85,11 +85,11 @@ gst_qt_get_gl_display (gboolean sink)
       GST_INFO ("returning previously created display");
       G_UNLOCK (display_lock);
       return display;
-    } else if (sink) {
-      sink_retrieved = sink;
     }
     gst_clear_object (&display);
   }
+  if (sink)
+    sink_retrieved = sink;
 
   GST_INFO ("QGuiApplication::instance()->platformName() %s", app->platformName().toUtf8().data());