ext/lame/gstlame.c: Don't leak the allowed caps.
authorSebastian Dröge <slomo@circular-chaos.org>
Mon, 11 Feb 2008 09:13:33 +0000 (09:13 +0000)
committerSebastian Dröge <slomo@circular-chaos.org>
Mon, 11 Feb 2008 09:13:33 +0000 (09:13 +0000)
Original commit message from CVS:
* ext/lame/gstlame.c: (gst_lame_setup):
Don't leak the allowed caps.
* tests/check/pipelines/lame.c: (GST_START_TEST):
Stop leaking all buffers. Fixes bug #515575.

ChangeLog
common
ext/lame/gstlame.c
tests/check/pipelines/lame.c

index fb0f900..ca69d97 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-02-11  Sebastian Dröge  <slomo@circular-chaos.org>
+
+       * ext/lame/gstlame.c: (gst_lame_setup):
+       Don't leak the allowed caps.
+       * tests/check/pipelines/lame.c: (GST_START_TEST):
+       Stop leaking all buffers. Fixes bug #515575.
+
 2008-02-08  Jan Schmidt  <jan.schmidt@sun.com>
 
        * gst/mpegaudioparse/plugin.c:
diff --git a/common b/common
index 8b37d7e..961bb6b 160000 (submodule)
--- a/common
+++ b/common
@@ -1 +1 @@
-Subproject commit 8b37d7ee833fab1d25b484d8574df3dae231b5f2
+Subproject commit 961bb6bd997d7c8da6058534e86b4a1361c0fcea
index bee623c..6e2d72f 100644 (file)
@@ -1200,6 +1200,8 @@ gst_lame_setup (GstLame * lame)
       GST_DEBUG_OBJECT (lame, "Letting lame choose sample rate");
       lame_set_out_samplerate (lame->lgf, 0);
     }
+    gst_caps_unref (allowed_caps);
+    allowed_caps = NULL;
   } else {
     GST_DEBUG_OBJECT (lame, "No peer yet, letting lame choose sample rate");
     lame_set_out_samplerate (lame->lgf, 0);
index e84d565..ec941f0 100644 (file)
@@ -58,6 +58,7 @@ GST_START_TEST (test_format)
 
   gst_buffer_straw_stop_pipeline (bin, pad);
 
+  gst_buffer_unref (buffer);
   gst_object_unref (pad);
   gst_object_unref (bin);
 }