drm/amdgpu/powerplay/ci: return an error if copying to smc fails
authorAlex Deucher <alexander.deucher@amd.com>
Mon, 30 Nov 2020 23:12:27 +0000 (18:12 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 2 Dec 2020 22:37:16 +0000 (17:37 -0500)
Rather than just silently dropping it.  Also fixes a set but
unused variable warning.

Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c

index 329bf4d..93a1c72 100644 (file)
@@ -2193,7 +2193,7 @@ static int ci_thermal_setup_fan_table(struct pp_hwmgr *hwmgr)
 
        res = ci_copy_bytes_to_smc(hwmgr, ci_data->fan_table_start, (uint8_t *)&fan_table, (uint32_t)sizeof(fan_table), SMC_RAM_END);
 
-       return 0;
+       return res;
 }
 
 static int ci_program_mem_timing_parameters(struct pp_hwmgr *hwmgr)