drm/msm/a6xx: Remove duplicate irq disable from remove
authorSean Paul <seanpaul@chromium.org>
Thu, 23 May 2019 17:16:41 +0000 (13:16 -0400)
committerSean Paul <seanpaul@chromium.org>
Fri, 24 May 2019 13:53:03 +0000 (09:53 -0400)
a6xx_gmu_stop() already calls this function via shutdown or force_stop,
so it's not necessary to call it twice. Previously this would have
knocked the irq refcount out of sync, but now with the irqs_enabled flag
it's just housekeeping.

Changes in v2:
- None

Cc: Jordan Crouse <jcrouse@codeaurora.org>
Reviewed-by: Jordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190523171653.138678-2-sean@poorly.run
drivers/gpu/drm/msm/adreno/a6xx_gmu.c

index aa84edb..742c8ff 100644 (file)
@@ -1239,7 +1239,6 @@ void a6xx_gmu_remove(struct a6xx_gpu *a6xx_gpu)
                dev_pm_domain_detach(gmu->gxpd, false);
        }
 
-       a6xx_gmu_irq_disable(gmu);
        a6xx_gmu_memory_free(gmu, gmu->hfi);
 
        iommu_detach_device(gmu->domain, gmu->dev);