[cmake] Emit an error for -DBUILD_SHARED_LIBS=ON on Windows
authorTom Stellard <tstellar@redhat.com>
Thu, 14 Nov 2019 17:18:44 +0000 (09:18 -0800)
committerTom Stellard <tstellar@redhat.com>
Thu, 14 Nov 2019 18:19:02 +0000 (10:19 -0800)
Summary:
The BUILD_SHARED_LIBS=ON build fails on Windows, so prevent users from
enabling it.

Reviewers: beanz, smeenai, compnerd, phosek

Reviewed By: beanz

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D70161

llvm/CMakeLists.txt

index 2a6ec2b..b1a51b3 100644 (file)
@@ -574,6 +574,9 @@ if(MSVC)
   # Set this variable to OFF here so it can't be set with a command-line
   # argument.
   set (LLVM_LINK_LLVM_DYLIB OFF)
+  if (BUILD_SHARED_LIBS)
+    message(FATAL_ERROR "BUILD_SHARED_LIBS options is not supported on Windows.")
+  endif()
 else()
   option(LLVM_LINK_LLVM_DYLIB "Link tools against the libllvm dynamic library" OFF)
   option(LLVM_BUILD_LLVM_C_DYLIB "Build libllvm-c re-export library (Darwin only)" OFF)