net: ngbe: use pci_dev_id() to simplify the code
authorZheng Zengkai <zhengzengkai@huawei.com>
Fri, 11 Aug 2023 11:07:02 +0000 (19:07 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 13 Aug 2023 11:30:39 +0000 (12:30 +0100)
PCI core API pci_dev_id() can be used to get the BDF number for a pci
device. We don't need to compose it manually. Use pci_dev_id() to
simplify the code a little bit.

Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/wangxun/ngbe/ngbe_mdio.c

index cc2f325..fe20f02 100644 (file)
@@ -266,8 +266,7 @@ int ngbe_mdio_init(struct wx *wx)
                mii_bus->write_c45 = ngbe_phy_write_reg_mdi_c45;
        }
 
-       snprintf(mii_bus->id, MII_BUS_ID_SIZE, "ngbe-%x",
-                (pdev->bus->number << 8) | pdev->devfn);
+       snprintf(mii_bus->id, MII_BUS_ID_SIZE, "ngbe-%x", pci_dev_id(pdev));
        ret = devm_mdiobus_register(&pdev->dev, mii_bus);
        if (ret)
                return ret;