delete only one older version of a xml-store resolvable

(half-baked, but the previous attempt was charred)
(#160792#c20)

diff --git a/package/libzypp.changes b/package/libzypp.changes
index eefb9d8..366b298 100644 (file)
--- a/package/libzypp.changes
+++ b/package/libzypp.changes
@@ -1,4 +1,10 @@
 -------------------------------------------------------------------
+Fri Apr 21 18:32:00 CEST 2006 - mvidner@suse.cz
+
+- delete only one older version of a xml-store resolvable
+  (half-baked, but the previous attempt was charred)
+
+-------------------------------------------------------------------
 Fri Apr 21 17:49:18 CEST 2006 - jsrain@suse.de
 
 - moved license_to_confirm to primary.xml

diff --git a/zypp/target/TargetImpl.cc b/zypp/target/TargetImpl.cc
index 73c9961..e547fec 100644 (file)
--- a/zypp/target/TargetImpl.cc
+++ b/zypp/target/TargetImpl.cc
@@ -388,7 +388,10 @@ namespace zypp
                  // #160792 do not just add, also remove older versions
                  if (true) // !installOnly - only on Package?!
                  {
-                   for (PoolItem_Ref old = Helper::findInstalledItem (pool_r, *it); old; )
+                   // this would delete the same item over and over
+                   //for (PoolItem_Ref old = Helper::findInstalledItem (pool_r, *it); old; )
+                   PoolItem_Ref old = Helper::findInstalledItem (pool_r, *it);
+                   if (old)
                    {
                      _storage.deleteObject(old.resolvable());
                    }