Copy the complete value table, not just the first 4 bytes. (#348136,

2006-07-21  Matthias Clasen  <mclasen@redhat.com>

	* gtypemodule.c (g_type_module_register_type): Copy the complete
	value table, not just the first 4 bytes.  (#348136, Coverity)

diff --git a/gobject/ChangeLog b/gobject/ChangeLog
index 6d987f0..98fbac0 100644 (file)
--- a/gobject/ChangeLog
+++ b/gobject/ChangeLog
@@ -1,3 +1,8 @@
+2006-07-21  Matthias Clasen  <mclasen@redhat.com>
+
+       * gtypemodule.c (g_type_module_register_type): Copy the complete
+       value table, not just the first 4 bytes.  (#348136, Coverity)
+
 2006-07-02  Matthias Clasen  <mclasen@redhat.com>
 
        * === Released 2.12.0 ===

diff --git a/gobject/gtypemodule.c b/gobject/gtypemodule.c
index 7a4ef21..47e5247 100644 (file)
--- a/gobject/gtypemodule.c
+++ b/gobject/gtypemodule.c
@@ -335,7 +335,7 @@ g_type_module_register_type (GTypeModule     *module,
   module_type_info->info = *type_info;
   if (type_info->value_table)
     module_type_info->info.value_table = g_memdup (type_info->value_table,
-                                                  sizeof (type_info->value_table));
+                                                  sizeof (GTypeValueTable));
 
   return module_type_info->type;
 }