selftests/bpf: Fix running of XDP bonding tests
authorJussi Maki <joamaki@gmail.com>
Wed, 11 Aug 2021 12:36:27 +0000 (12:36 +0000)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 13 Aug 2021 21:48:16 +0000 (23:48 +0200)
An "innocent" cleanup in the last version of the XDP bonding patchset moved
the "test__start_subtest" calls to the test main function, but I forgot to
reverse the condition, which lead to all tests being skipped. Fix it.

Fixes: 6aab1c81b98a ("selftests/bpf: Add tests for XDP bonding")
Signed-off-by: Jussi Maki <joamaki@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20210811123627.20223-1-joamaki@gmail.com
tools/testing/selftests/bpf/prog_tests/xdp_bonding.c

index 6b186b4..370d220 100644 (file)
@@ -493,20 +493,20 @@ void test_xdp_bonding(void)
                           "xdp_redirect_multi_kern__open_and_load"))
                goto out;
 
-       if (!test__start_subtest("xdp_bonding_attach"))
+       if (test__start_subtest("xdp_bonding_attach"))
                test_xdp_bonding_attach(&skeletons);
 
        for (i = 0; i < ARRAY_SIZE(bond_test_cases); i++) {
                struct bond_test_case *test_case = &bond_test_cases[i];
 
-               if (!test__start_subtest(test_case->name))
+               if (test__start_subtest(test_case->name))
                        test_xdp_bonding_with_mode(
                                &skeletons,
                                test_case->mode,
                                test_case->xmit_policy);
        }
 
-       if (!test__start_subtest("xdp_bonding_redirect_multi"))
+       if (test__start_subtest("xdp_bonding_redirect_multi"))
                test_xdp_bonding_redirect_multi(&skeletons);
 
 out: