i2c: nomadik: Fix the usage of wait_for_completion_timeout
authorChuansheng Liu <chuansheng.liu@intel.com>
Tue, 6 Nov 2012 17:18:37 +0000 (01:18 +0800)
committerWolfram Sang <w.sang@pengutronix.de>
Mon, 12 Nov 2012 17:21:55 +0000 (18:21 +0100)
The return value of wait_for_completion_timeout() is always
>= 0 with unsigned int type.

So the condition "ret < 0" or "ret >= 0" is pointless.

Signed-off-by: liu chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
drivers/i2c/busses/i2c-nomadik.c

index 02c3115..8b2ffcf 100644 (file)
@@ -435,13 +435,6 @@ static int read_i2c(struct nmk_i2c_dev *dev, u16 flags)
        timeout = wait_for_completion_timeout(
                &dev->xfer_complete, dev->adap.timeout);
 
-       if (timeout < 0) {
-               dev_err(&dev->adev->dev,
-                       "wait_for_completion_timeout "
-                       "returned %d waiting for event\n", timeout);
-               status = timeout;
-       }
-
        if (timeout == 0) {
                /* Controller timed out */
                dev_err(&dev->adev->dev, "read from slave 0x%x timed out\n",
@@ -523,13 +516,6 @@ static int write_i2c(struct nmk_i2c_dev *dev, u16 flags)
        timeout = wait_for_completion_timeout(
                &dev->xfer_complete, dev->adap.timeout);
 
-       if (timeout < 0) {
-               dev_err(&dev->adev->dev,
-                       "wait_for_completion_timeout "
-                       "returned %d waiting for event\n", timeout);
-               status = timeout;
-       }
-
        if (timeout == 0) {
                /* Controller timed out */
                dev_err(&dev->adev->dev, "write to slave 0x%x timed out\n",