set -Wno-implicit-fallthrough on GCC too
authorMike Klein <mtklein@chromium.org>
Thu, 22 Feb 2018 20:36:24 +0000 (15:36 -0500)
committerMatthew Leibowitz <mattleibow@live.com>
Wed, 28 Feb 2018 16:30:55 +0000 (18:30 +0200)
Bug: skia:7643

Change-Id: Ieeca5414f51c7c113c54b47578ec840fc7d684e0
Reviewed-on: https://skia-review.googlesource.com/109520
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

gn/BUILD.gn

index 693c39a..aa7f320 100644 (file)
@@ -372,7 +372,6 @@ config("warnings") {
       cflags += [
         "-Wno-covered-switch-default",
         "-Wno-deprecated",
-        "-Wno-implicit-fallthrough",
         "-Wno-missing-noreturn",
         "-Wno-old-style-cast",
         "-Wno-padded",
@@ -388,6 +387,9 @@ config("warnings") {
       ]
     }
   }
+  if (!is_win || is_clang) {
+    cflags += [ "-Wno-implicit-fallthrough" ]
+  }
 }
 config("warnings_except_public_headers") {
   if (!is_win) {