s390/con3270: testing return kzalloc retval
authorPierre Morel <pmorel@linux.vnet.ibm.com>
Mon, 21 Dec 2015 14:31:06 +0000 (15:31 +0100)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Wed, 30 Dec 2015 09:34:33 +0000 (10:34 +0100)
Return value from kzalloc is not tested and
using a null pointer would lead to crash.

Even if this should not happen at this moment, we
may let the system decide if there is a better choice.

Signed-off-by: Pierre Morel <pmorel@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
drivers/s390/char/con3270.c

index 7c511ad..4d7a9ba 100644 (file)
@@ -606,6 +606,8 @@ con3270_init(void)
                return PTR_ERR(rp);
 
        condev = kzalloc(sizeof(struct con3270), GFP_KERNEL | GFP_DMA);
+       if (!condev)
+               return -ENOMEM;
        condev->view.dev = rp;
 
        condev->read = raw3270_request_alloc(0);