Fix Coverity issue 87/232587/1
authorMateusz Moscicki <m.moscicki2@partner.samsung.com>
Wed, 6 May 2020 10:52:36 +0000 (12:52 +0200)
committerMateusz Moscicki <m.moscicki2@partner.samsung.com>
Wed, 6 May 2020 13:27:59 +0000 (15:27 +0200)
dirname() could return pointer to the local variable

Change-Id: I886df1d2abf73d49f20c11e7ed5eef4595d1c6c5

src/crash-manager/so-info.c

index d2526d7..6dc61d4 100644 (file)
@@ -462,10 +462,9 @@ bool correct_file_path(const char *file_path, char *buff, size_t len)
 
        strncpy(file_path_copy, file_path, sizeof(file_path_copy) - 1);
        char *dir_name = dirname(file_path_copy);
+       char tmp_dir_name[PATH_MAX];
 
        if (!file_exists_in_dir(dir_name, dll_name)) {
-               char tmp_dir_name[PATH_MAX];
-
                strncpy(tmp_dir_name, dir_name, sizeof(tmp_dir_name) - 1);
                dir_name = dirname(tmp_dir_name);