media: imx: capture: Remove capture_priv stop field
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 15 Feb 2021 04:26:36 +0000 (05:26 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Mar 2021 10:59:47 +0000 (11:59 +0100)
The stop field in the capture_priv structure is only set, never read.
Drop it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/imx/imx-media-capture.c

index 933ebc6..4cee7ba 100644 (file)
@@ -45,8 +45,6 @@ struct capture_priv {
        spinlock_t q_lock;                      /* Protect ready_q */
 
        struct v4l2_ctrl_handler ctrl_hdlr;     /* Controls inherited from subdevs */
-
-       bool stop;                              /* streaming is stopping */
 };
 
 #define to_capture_priv(v) container_of(v, struct capture_priv, vdev)
@@ -573,8 +571,6 @@ static int capture_start_streaming(struct vb2_queue *vq, unsigned int count)
                goto return_bufs;
        }
 
-       priv->stop = false;
-
        return 0;
 
 return_bufs:
@@ -595,10 +591,6 @@ static void capture_stop_streaming(struct vb2_queue *vq)
        unsigned long flags;
        int ret;
 
-       spin_lock_irqsave(&priv->q_lock, flags);
-       priv->stop = true;
-       spin_unlock_irqrestore(&priv->q_lock, flags);
-
        ret = imx_media_pipeline_set_stream(priv->md, &priv->src_sd->entity,
                                            false);
        if (ret)