fpga: spartan2: Fix printf arguments warning
authorAlexander Dahl <ada@thorsis.com>
Fri, 7 Oct 2022 12:19:55 +0000 (14:19 +0200)
committerMichal Simek <michal.simek@amd.com>
Mon, 10 Oct 2022 10:28:08 +0000 (12:28 +0200)
That extra comma messes up format arguments.
Warning appears if built with FPGA_DEBUG defined:

      CC      drivers/fpga/spartan2.o
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan2.c: In function ‘spartan2_sp_load’:
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan2.c:112:11: warning: too many arguments for format [-Wformat-extra-args]
       PRINTF ("%s: Function Table:\n"
               ^~~~~~~~~~~~~~~~~~~~~~~
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan2.c:12:37: note: in definition of macro ‘PRINTF’
     #define PRINTF(fmt,args...) printf (fmt ,##args)
                                         ^~~
      CC      drivers/fpga/spartan3.o
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c: In function ‘spartan3_sp_load’:
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c:117:11: warning: too many arguments for format [-Wformat-extra-args]
       PRINTF ("%s: Function Table:\n"
               ^~~~~~~~~~~~~~~~~~~~~~~
    /mnt/data/adahl/src/u-boot/drivers/fpga/spartan3.c:17:37: note: in definition of macro ‘PRINTF’
     #define PRINTF(fmt,args...) printf (fmt ,##args)
                                         ^~~

Fixes: e221174377d7 ("Initial revision")
Signed-off-by: Alexander Dahl <ada@thorsis.com>
Signed-off-by: Michal Simek <michal.simek@amd.com>
Link: https://lore.kernel.org/r/20221007122003.11239-3-ada@thorsis.com
drivers/fpga/spartan2.c

index 47692e32076b39fd6f9608055bbbefb65b5553a3..3817ad8bb7711856c2d43546f50d6ac51fcac8d2 100644 (file)
@@ -122,7 +122,7 @@ static int spartan2_sp_load(xilinx_desc *desc, const void *buf, size_t bsize)
                                "read data:\t0x%p\n"
                                "write data:\t0x%p\n"
                                "busy:\t0x%p\n"
-                               "abort:\t0x%p\n",
+                               "abort:\t0x%p\n"
                                "post:\t0x%p\n\n",
                                __FUNCTION__, &fn, fn, fn->pre, fn->pgm, fn->init, fn->err,
                                fn->clk, fn->cs, fn->wr, fn->rdata, fn->wdata, fn->busy,