scsi: qla4xxx: Remove redundant assignment to variable rval

The variable rval has been initialized with 'QLA_ERROR'. The assignment is
redundant in an error path. Remove it.

Link: https://lore.kernel.org/r/20201103120137.109717-1-jingxiangfeng@huawei.com
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index 2c23b69..a4b014e 100644 (file)
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -685,7 +685,6 @@ static int qla4xxx_get_chap_by_index(struct scsi_qla_host *ha,
 
        if (!ha->chap_list) {
                ql4_printk(KERN_ERR, ha, "CHAP table cache is empty!\n");
-               rval = QLA_ERROR;
                goto exit_get_chap;
        }
 
@@ -697,14 +696,12 @@ static int qla4xxx_get_chap_by_index(struct scsi_qla_host *ha,
 
        if (chap_index > max_chap_entries) {
                ql4_printk(KERN_ERR, ha, "Invalid Chap index\n");
-               rval = QLA_ERROR;
                goto exit_get_chap;
        }
 
        *chap_entry = (struct ql4_chap_table *)ha->chap_list + chap_index;
        if ((*chap_entry)->cookie !=
             __constant_cpu_to_le16(CHAP_VALID_COOKIE)) {
-               rval = QLA_ERROR;
                *chap_entry = NULL;
        } else {
                rval = QLA_SUCCESS;