net: hns3: Fix for using wrong mask and shift in hclge_get_ring_chain_from_mbx
authorFuyun Liang <liangfuyun1@huawei.com>
Mon, 16 Jul 2018 15:36:26 +0000 (16:36 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 16 Jul 2018 18:16:45 +0000 (11:16 -0700)
HCLGE_INT_GL_IDX_M and HCLGE_INT_GL_IDX_S are used to set fireware
cmd. When getting int_gl value from mailbox message, we should use
HNAE3_RING_GL_IDX_M and HNAE3_RING_GL_IDX_S.

Fixes: 79eee4108541 ("net: hns3: add int_gl_idx setup for VF")
Signed-off-by: Fuyun Liang <liangfuyun1@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

index 50ae2f8..9d36bcc 100644 (file)
@@ -131,8 +131,8 @@ static int hclge_get_ring_chain_from_mbx(
        hnae3_set_bit(ring_chain->flag, HNAE3_RING_TYPE_B, req->msg[3]);
        ring_chain->tqp_index =
                        hclge_get_queue_id(vport->nic.kinfo.tqp[req->msg[4]]);
-       hnae3_set_field(ring_chain->int_gl_idx, HCLGE_INT_GL_IDX_M,
-                       HCLGE_INT_GL_IDX_S,
+       hnae3_set_field(ring_chain->int_gl_idx, HNAE3_RING_GL_IDX_M,
+                       HNAE3_RING_GL_IDX_S,
                        req->msg[5]);
 
        cur_chain = ring_chain;
@@ -151,8 +151,8 @@ static int hclge_get_ring_chain_from_mbx(
                        [req->msg[HCLGE_MBX_RING_NODE_VARIABLE_NUM * i +
                        HCLGE_MBX_RING_MAP_BASIC_MSG_NUM + 1]]);
 
-               hnae3_set_field(new_chain->int_gl_idx, HCLGE_INT_GL_IDX_M,
-                               HCLGE_INT_GL_IDX_S,
+               hnae3_set_field(new_chain->int_gl_idx, HNAE3_RING_GL_IDX_M,
+                               HNAE3_RING_GL_IDX_S,
                                req->msg[HCLGE_MBX_RING_NODE_VARIABLE_NUM * i +
                                HCLGE_MBX_RING_MAP_BASIC_MSG_NUM + 2]);