net: ethernet: mediatek: mtk_eth_soc: Add of_node_put() before goto

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a goto from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the goto.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index b20b3a5a1ebb39160c111bc6657b84434d62636a..c39d7f4ab1d4c036df56ed0e0ed5a2422f2c77d3 100644 (file)
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2548,8 +2548,10 @@ static int mtk_probe(struct platform_device *pdev)
                        continue;
 
                err = mtk_add_mac(eth, mac_np);
-               if (err)
+               if (err) {
+                       of_node_put(mac_np);
                        goto err_deinit_hw;
+               }
        }
 
        if (MTK_HAS_CAPS(eth->soc->caps, MTK_SHARED_INT)) {