staging: qlge: Remove useless dma synchronization calls
authorBenjamin Poirier <bpoirier@suse.com>
Fri, 27 Sep 2019 10:12:01 +0000 (19:12 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2019 15:17:45 +0000 (17:17 +0200)
This is unneeded for two reasons:
1) the cpu does not write data for the device in the mapping
2) calls like ..._sync_..._for_device(..., ..._FROMDEVICE) are
   nonsensical, see commit 3f0fb4e85b38 ("Documentation/DMA-API-HOWTO.txt:
   fix misleading example")

Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Link: https://lore.kernel.org/r/20190927101210.23856-8-bpoirier@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/qlge/qlge_main.c

index 0a3809c..0340371 100644 (file)
@@ -1110,9 +1110,6 @@ static void ql_update_lbq(struct ql_adapter *qdev, struct rx_ring *rx_ring)
                        dma_unmap_addr_set(lbq_desc, mapaddr, map);
                        *lbq_desc->addr = cpu_to_le64(map);
 
-                       pci_dma_sync_single_for_device(qdev->pdev, map,
-                                                      qdev->lbq_buf_size,
-                                                      PCI_DMA_FROMDEVICE);
                        clean_idx++;
                        if (clean_idx == rx_ring->lbq_len)
                                clean_idx = 0;
@@ -1598,10 +1595,6 @@ static void ql_process_mac_rx_skb(struct ql_adapter *qdev,
 
        skb_put_data(new_skb, skb->data, length);
 
-       pci_dma_sync_single_for_device(qdev->pdev,
-                                      dma_unmap_addr(sbq_desc, mapaddr),
-                                      SMALL_BUF_MAP_SIZE,
-                                      PCI_DMA_FROMDEVICE);
        skb = new_skb;
 
        /* Frame error, so drop the packet. */
@@ -1757,11 +1750,6 @@ static struct sk_buff *ql_build_rx_skb(struct ql_adapter *qdev,
                                                    SMALL_BUF_MAP_SIZE,
                                                    PCI_DMA_FROMDEVICE);
                        skb_put_data(skb, sbq_desc->p.skb->data, length);
-                       pci_dma_sync_single_for_device(qdev->pdev,
-                                                      dma_unmap_addr(sbq_desc,
-                                                                     mapaddr),
-                                                      SMALL_BUF_MAP_SIZE,
-                                                      PCI_DMA_FROMDEVICE);
                } else {
                        netif_printk(qdev, rx_status, KERN_DEBUG, qdev->ndev,
                                     "%d bytes in a single small buffer.\n",