ASoC: qcom: remove IS_ERR_VALUE usage on int.
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Thu, 31 Mar 2016 18:23:15 +0000 (19:23 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 31 Mar 2016 18:43:08 +0000 (11:43 -0700)
IS_ERR_VALUE should be used only with unsigned long type,
signed types should use comparison 'ret < 0'

This patch removes such usages.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/lpass-platform.c

index f5cae01..db000c6 100644 (file)
@@ -491,7 +491,7 @@ static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime)
                        data->rdma_ch = v->alloc_dma_channel(drvdata,
                                                SNDRV_PCM_STREAM_PLAYBACK);
 
-               if (IS_ERR_VALUE(data->rdma_ch))
+               if (data->rdma_ch < 0)
                        return data->rdma_ch;
 
                drvdata->substream[data->rdma_ch] = psubstream;
@@ -518,8 +518,10 @@ static int lpass_platform_pcm_new(struct snd_soc_pcm_runtime *soc_runtime)
                        data->wrdma_ch = v->alloc_dma_channel(drvdata,
                                                SNDRV_PCM_STREAM_CAPTURE);
 
-               if (IS_ERR_VALUE(data->wrdma_ch))
+               if (data->wrdma_ch < 0) {
+                       ret = data->wrdma_ch;
                        goto capture_alloc_err;
+               }
 
                drvdata->substream[data->wrdma_ch] = csubstream;