Staging: et131x: tx ring mac error is only used as a local
authorAlan Cox <alan@linux.intel.com>
Tue, 6 Oct 2009 14:50:05 +0000 (15:50 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 11 Dec 2009 20:23:07 +0000 (12:23 -0800)
So make it a local

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/et131x/et1310_tx.h
drivers/staging/et131x/et131x_isr.c

index 60bb2c8..4f0ea81 100644 (file)
@@ -143,9 +143,7 @@ struct tx_ring {
        u32 *tx_status;
        dma_addr_t tx_status_pa;
 
-       TXMAC_ERR_t TxMacErr;
-
-       /* Variables to track the Tx interrupt coalescing features */
+       /* Packets since the last IRQ: used for interrupt coalescing */
        int since_irq;
 };
 
index b6dab8c..ccd9bc2 100644 (file)
@@ -397,8 +397,7 @@ void et131x_isr_handler(struct work_struct *work)
 
                /* Let's move on to the TxMac */
                if (status & ET_INTR_TXMAC) {
-                       etdev->tx_ring.TxMacErr.value =
-                               readl(&iomem->txmac.err.value);
+                       u32 err = readl(&iomem->txmac.err.value);
 
                        /*
                         * When any of the errors occur and TXMAC generates
@@ -412,7 +411,7 @@ void et131x_isr_handler(struct work_struct *work)
                         */
                        dev_warn(&etdev->pdev->dev,
                                    "TXMAC interrupt, error 0x%08x\n",
-                                   etdev->tx_ring.TxMacErr.value);
+                                   err);
 
                        /* If we are debugging, we want to see this error,
                         * otherwise we just want the device to be reset and