media: v4l: async: Avoid a goto in loop implementation
authorSakari Ailus <sakari.ailus@linux.intel.com>
Sat, 29 Jul 2023 11:52:14 +0000 (13:52 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Thu, 10 Aug 2023 05:58:39 +0000 (07:58 +0200)
Replace a goto-based loop by a while loop.

Suggested-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/v4l2-core/v4l2-async.c

index f465a09..091e8cf 100644 (file)
@@ -820,20 +820,16 @@ int v4l2_async_register_subdev(struct v4l2_subdev *sd)
                if (!v4l2_dev)
                        continue;
 
-again:
-               asc = v4l2_async_find_match(notifier, sd);
-               if (!asc)
-                       continue;
-
-               ret = v4l2_async_match_notify(notifier, v4l2_dev, sd, asc);
-               if (ret)
-                       goto err_unbind;
-
-               ret = v4l2_async_nf_try_complete(notifier);
-               if (ret)
-                       goto err_unbind;
-
-               goto again;
+               while ((asc = v4l2_async_find_match(notifier, sd))) {
+                       ret = v4l2_async_match_notify(notifier, v4l2_dev, sd,
+                                                     asc);
+                       if (ret)
+                               goto err_unbind;
+
+                       ret = v4l2_async_nf_try_complete(notifier);
+                       if (ret)
+                               goto err_unbind;
+               }
        }
 
        /* None matched, wait for hot-plugging */