Lookup in dict

diff --git a/jenkinsapi/nodes.py b/jenkinsapi/nodes.py
index 81e8379a2ae8da363d69231abd48e6186f0c025c..d3ec02b5481e8c517d4b36a91ad484f3c665a344 100644 (file)
--- a/jenkinsapi/nodes.py
+++ b/jenkinsapi/nodes.py
@@ -52,10 +52,11 @@ class Nodes(JenkinsBase):
                 ipdb.set_trace()
 
     def __getitem__(self, nodename):
-        for k, v in self.iteritems():
-            if k == nodename:
-                return v
-        raise UnknownNode(nodename)
+        self_as_dict = dict(self.iteritems())
+        if nodename in self_as_dict:
+            return self_as_dict[nodename]
+        else:
+            raise UnknownNode(nodename)
 
     def __len__(self):
         return len(self.iteritems())

diff --git a/jenkinsapi/result_set.py b/jenkinsapi/result_set.py
index 52b5b350d6d89aab8d93e44e827e9de8ff120f3f..a7657429cd21d91dc6f8936a8ca206c812b198f8 100644 (file)
--- a/jenkinsapi/result_set.py
+++ b/jenkinsapi/result_set.py
@@ -51,5 +51,5 @@ class ResultSet(JenkinsBase):
         return len(self.items())
 
     def __getitem__(self, key):
-        d = dict(self.iteritems())
-        return d[key]
+        self_as_dict = dict(self.iteritems())
+        return self_as_dict[key]