Reenable superpmi test for x86
authorBruce Forstall <brucefo@microsoft.com>
Mon, 22 Aug 2016 21:10:50 +0000 (14:10 -0700)
committerBruce Forstall <brucefo@microsoft.com>
Mon, 22 Aug 2016 21:10:50 +0000 (14:10 -0700)
Replace Roslyn CscBench with Bytemark, since CscBench fails with
an inlining assert (opened as issue #6844) on x86.

tests/issues.targets
tests/src/JIT/superpmi/superpmicollect.cs
tests/x86_legacy_backend_issues.targets

index 0330d5d1adfed8b81db48ef2d48c33ea34c100b0..7b31faea7e23d52525c07d7373e3811da49a145c 100644 (file)
              <Issue>needs triage</Issue>
         </ExcludeList>
         <ExcludeList Include="$(XunitTestBinBase)\JIT\Performance\CodeQuality\Roslyn\CscBench\CscBench.cmd">
-             <Issue>needs triage</Issue>
+             <Issue>6844</Issue>
         </ExcludeList>
         <ExcludeList Include="$(XunitTestBinBase)\JIT\Regression\CLR-x86-JIT\V1.2-Beta1\b103058\b103058\b103058.cmd">
              <Issue>needs triage</Issue>
         <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\int64\superlong\_il_relsuperlong\_il_relsuperlong.cmd">
              <Issue>6778</Issue>
         </ExcludeList>
-        <ExcludeList Include="$(XunitTestBinBase)\JIT\superpmi\superpmicollect\superpmicollect.cmd">
-             <Issue>6830</Issue>
-        </ExcludeList>
     </ItemGroup>
     
     <!-- Tests that need to be triaged for vararg usage as that is not supported -->
index 02f15bb5c24fe0876b42121f6c47b6862c8b9a19..4faa5e65b198a3551d6b2b4f3a0a713510002ce8 100644 (file)
@@ -259,9 +259,13 @@ namespace SuperPMICollection
             // is changed.
             //
             // TODO: this should probably be loaded dynamically from a .json/.xml file.
+            //
+            // Note: We previously used
+            //      JIT\Performance\CodeQuality\Roslyn\CscBench\CscBench.cmd
+            // but it doesn't currently run on x86 due to this issue: https://github.com/dotnet/coreclr/issues/6844.
             string[] SuperPMICollectionTestProgramsList =
             {
-                @"JIT\Performance\CodeQuality\Roslyn\CscBench\CscBench.cmd",
+                @"JIT\Performance\CodeQuality\Bytemark\Bytemark\Bytemark.cmd",
                 @"JIT\Methodical\fp\exgen\10w5d_cs_do\10w5d_cs_do.cmd",
                 @"JIT\Generics\Coverage\chaos65204782cs\chaos65204782cs.cmd"
             };
index 6f036c2bbd4beb6c15406f3624ae0dc8f1c1d361..6098e0be7028f3987a6d6144a47b2047d056f3fd 100644 (file)
       <Issue>needs triage</Issue>
     </ExcludeList>
     <ExcludeList Include="$(XunitTestBinBase)\JIT\Performance\CodeQuality\Roslyn\CscBench\CscBench.cmd">
-      <Issue>needs triage</Issue>
+      <Issue>6844</Issue>
     </ExcludeList>
     <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\delegate\_simpleoddpower_il_r\_simpleoddpower_il_r.cmd">
       <Issue>needs triage</Issue>
     <ExcludeList Include="$(XunitTestBinBase)\baseservices\threading\waithandle\waitall\waitallex8a\*">
       <Issue>3832</Issue>
     </ExcludeList>
-    <ExcludeList Include="$(XunitTestBinBase)\JIT\superpmi\superpmicollect\superpmicollect.cmd">
-         <Issue>6830</Issue>
-    </ExcludeList>
     <ExcludeList Include="$(XunitTestBinBase)\JIT\Methodical\tailcall_v4\smallFrame\smallFrame.cmd">
       <Issue>tail. call pop ret is only supported on amd64</Issue>
     </ExcludeList>