liquidio: avoid doing useless work

Avoid doing useless work by making sure that the response_list is not empty
before scheduling work to process it.

Signed-off-by: Prasad Kanneganti <prasad.kanneganti@cavium.com>
Signed-off-by: Felix Manlunas <felix.manlunas@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
index e07d209..2766af0 100644 (file)
--- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
+++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
@@ -366,6 +366,7 @@ int
 lio_process_iq_request_list(struct octeon_device *oct,
                            struct octeon_instr_queue *iq, u32 napi_budget)
 {
+       struct cavium_wq *cwq = &oct->dma_comp_wq;
        int reqtype;
        void *buf;
        u32 old = iq->flush_index;
@@ -450,6 +451,10 @@ lio_process_iq_request_list(struct octeon_device *oct,
                                                   bytes_compl);
        iq->flush_index = old;
 
+       if (atomic_read(&oct->response_list
+                       [OCTEON_ORDERED_SC_LIST].pending_req_count))
+               queue_delayed_work(cwq->wq, &cwq->wk.work, msecs_to_jiffies(1));
+
        return inst_count;
 }
 

diff --git a/drivers/net/ethernet/cavium/liquidio/response_manager.c b/drivers/net/ethernet/cavium/liquidio/response_manager.c
index 3d691c6..fe5b537 100644 (file)
--- a/drivers/net/ethernet/cavium/liquidio/response_manager.c
+++ b/drivers/net/ethernet/cavium/liquidio/response_manager.c
@@ -49,7 +49,6 @@ int octeon_setup_response_list(struct octeon_device *oct)
        INIT_DELAYED_WORK(&cwq->wk.work, oct_poll_req_completion);
        cwq->wk.ctxptr = oct;
        oct->cmd_resp_state = OCT_DRV_ONLINE;
-       queue_delayed_work(cwq->wq, &cwq->wk.work, msecs_to_jiffies(50));
 
        return ret;
 }
@@ -164,5 +163,8 @@ static void oct_poll_req_completion(struct work_struct *work)
        struct cavium_wq *cwq = &oct->dma_comp_wq;
 
        lio_process_ordered_list(oct, 0);
-       queue_delayed_work(cwq->wq, &cwq->wk.work, msecs_to_jiffies(50));
+
+       if (atomic_read(&oct->response_list
+                       [OCTEON_ORDERED_SC_LIST].pending_req_count))
+               queue_delayed_work(cwq->wq, &cwq->wk.work, msecs_to_jiffies(1));
 }