gst/mpegstream/: Ref events before sending them to multiple pads, after all gst_pad_s...

Original commit message from CVS:
Reviewed by: Tim-Philipp Müller  <tim at centricular dot net>
* gst/mpegstream/gstmpegdemux.c: (gst_mpeg_demux_send_event):
* gst/mpegstream/gstmpegparse.c: (gst_mpeg_parse_send_newsegment),
(gst_mpeg_parse_send_event):
Ref events before sending them to multiple pads, after all
gst_pad_send_event() takes ownership of events. Don't leak
events that have not been handled (fixes #322745).

diff --git a/ChangeLog b/ChangeLog
index 55daa8aa2a2e8abd231258fc5e867fa8a972cc91..14752eb06db3193cbfddb0a906522c678ec00287 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2005-11-29  Michal Benes  <michal dot benes at xeris dot cz>
+
+       Reviewed by: Tim-Philipp Müller  <tim at centricular dot net>
+
+       * gst/mpegstream/gstmpegdemux.c: (gst_mpeg_demux_send_event):
+       * gst/mpegstream/gstmpegparse.c: (gst_mpeg_parse_send_newsegment),
+       (gst_mpeg_parse_send_event):
+         Ref events before sending them to multiple pads, after all
+         gst_pad_send_event() takes ownership of events. Don't leak
+         events that have not been handled (fixes #322745).
+
 2005-11-28  Martin Soto  <martinsoto@users.sourceforge.net>
 
        * gst/mpegstream/gstdvddemux.c (gst_dvd_demux_handle_dvd_event)

diff --git a/common b/common
index b0b08bcd66ca385364b6f90663585b09693aec67..33084fbe0531733bc02aa1d9de608206d5553a15 160000 (submodule)
--- a/common
+++ b/common
@@ -1 +1 @@
-Subproject commit b0b08bcd66ca385364b6f90663585b09693aec67
+Subproject commit 33084fbe0531733bc02aa1d9de608206d5553a15

diff --git a/gst/mpegstream/gstmpegdemux.c b/gst/mpegstream/gstmpegdemux.c
index 01629fd009d0d6b298e9f097a94d76d023c1d72c..07b02329fa4bcd3d3da6020a830f6cff22fd09f1 100644 (file)
--- a/gst/mpegstream/gstmpegdemux.c
+++ b/gst/mpegstream/gstmpegdemux.c
@@ -317,6 +317,8 @@ gst_mpeg_demux_send_event (GstMPEGParse * mpeg_parse, GstEvent * event,
 
   if (parent_class->send_event)
     return parent_class->send_event (mpeg_parse, event, time);
+  else
+    gst_event_unref (event);
 
   return TRUE;
 }

diff --git a/gst/mpegstream/gstmpegparse.c b/gst/mpegstream/gstmpegparse.c
index 351e0086c1b0e3f5a73ec943544abd1d784e2013..70484d551a960b06ba876d9ea52a91abf345fcd6 100644 (file)
--- a/gst/mpegstream/gstmpegparse.c
+++ b/gst/mpegstream/gstmpegparse.c
@@ -364,6 +364,7 @@ gst_mpeg_parse_send_newsegment (GstMPEGParse * mpeg_parse, gdouble rate,
     return CLASS (mpeg_parse)->send_event (mpeg_parse, event, start_time);
   }
 
+  gst_event_unref (event);
   return FALSE;
 }
 
@@ -380,6 +381,7 @@ gst_mpeg_parse_send_event (GstMPEGParse * mpeg_parse, GstEvent * event,
   while (TRUE) {
     switch (gst_iterator_next (it, &pad)) {
       case GST_ITERATOR_OK:
+        gst_event_ref (event);
         gst_pad_push_event (GST_PAD (pad), event);
         gst_object_unref (GST_OBJECT (pad));
         break;
@@ -396,6 +398,7 @@ gst_mpeg_parse_send_event (GstMPEGParse * mpeg_parse, GstEvent * event,
 
 done:
   gst_iterator_free (it);
+  gst_event_unref (event);
 
   return ret;
 }